Day-of-week 7 passes the new rule, and K3s then takes no snapshots
What I found
isValidCronSchedule passes allowSevenAsSunday: true, and a test row pins 0 0 * * 7 as valid. K3s and RKE2 parse this with robfig/cron/v3, whose day of week is 0-6, so it answers end of range (7) above maximum (6). K3s ignores the error from AddJob, so nothing fails visibly. On master the option only affected a hint. This PR makes it the Save gate.
I started four throwaway K3s v1.33.5 servers with --cluster-init and left them for 4 minutes:
| Schedule | PR form | Node | Snapshots | Cron error in logs |
|---|---|---|---|---|
* * * * 0-6 | Allows | Ready | 4 | – |
* * * * 0-7 | Allows | Ready | 0 | None |
* * * * * * (the issue) | Blocks | Ready | 0 | None |
@every 1m (card 2) | Blocks | Ready | 3 | – |
0 0 * * 7. Create is enabled and the hint says "only on Sunday".Fix
Drop allowSevenAsSunday from isValidCronSchedule and flip the test row. Run against the matrix below, that turns all four 7 rows into blocks and changes nothing else. Adding "day of week is 0-6" to the message would help, because the shared LabeledInput hint keeps its own copy of the check and will still describe 7 as Sunday. I'd leave that hint alone, since other cron forms use it.
Limit: I ran K3s, not RKE2. RKE2 pulls in K3s's etcd package (go.mod), and Rancher passes the schedule through unchanged, but I read those rather than provisioning a node.